Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pg_init_privs objsubid handling #3336

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Jun 15, 2021

pg_init_privs can have multiple entries per relation if the relation
has per column privileges. An objsubid different from 0 means that
the entry is for a column privilege. Since we do not currently
restore column privileges we have to ignore those rows otherwise
the update script will fail when tables with column privileges are
present.

Fixes #3331

@svenklemm svenklemm requested a review from a team as a code owner June 15, 2021 06:19
@svenklemm svenklemm requested review from pmwkaa, nikkhils, mfundul, mkindahl and gayyappan and removed request for a team June 15, 2021 06:19
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svenklemm svenklemm self-assigned this Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #3336 (e6658fb) into master (001f5d9) will decrease coverage by 1.60%.
The diff coverage is 90.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3336      +/-   ##
==========================================
- Coverage   92.17%   90.56%   -1.61%     
==========================================
  Files         110      211     +101     
  Lines       14177    35479   +21302     
==========================================
+ Hits        13067    32131   +19064     
- Misses       1110     3348    +2238     
Impacted Files Coverage Δ
src/bgw/launcher_interface.c 72.22% <ø> (+1.63%) ⬆️
src/catalog.h 100.00% <ø> (ø)
src/chunk.c 95.90% <ø> (+1.37%) ⬆️
src/chunk_constraint.c 94.28% <ø> (+0.87%) ⬆️
src/chunk_data_node.c 91.91% <ø> (ø)
src/chunk_index.c 94.72% <ø> (+5.99%) ⬆️
src/chunk_index.h 100.00% <ø> (ø)
src/compat.h 100.00% <ø> (+20.00%) ⬆️
src/compression_chunk_size.c 94.91% <ø> (ø)
src/compression_with_clause.c 87.06% <ø> (ø)
... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc4e09...e6658fb. Read the comment docs.

Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pg_init_privs can have multiple entries per relation if the relation
has per column privileges. An objsubid different from 0 means that
the entry is for a column privilege. Since we do not currently
restore column privileges we have to ignore those rows otherwise
the update script will fail when tables with column privileges are
present.
@svenklemm svenklemm merged commit 6d6172b into timescale:master Jun 15, 2021
@fvannee
Copy link
Contributor

fvannee commented Jun 15, 2021

To me this looks like it fixes the case where objsubid != 0, however I don't think that was the actual issue in our case.
I don't have the full details anymore I'm afraid.. But what I know was that, in both cases that I ran into the error, I had two rows in pg_init_privs with the same objoid and a different classoid. In none of the cases I had set any kind of per-column privileges.

In order to fix the catalog, I ran this:

delete from pg_init_privs where objoid=16405 and classoid=1259;

This deleted 1 row from the catalog table and the other row with objoid=16405 remained.

@svenklemm
Copy link
Member Author

@fvannee Thanks for the update i've created a PR to limit the query to only pg_class classoids to prevent this from happening.

#3338

mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
@mkindahl mkindahl mentioned this pull request Jul 1, 2021
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit that referenced this pull request Jul 2, 2021
**Bugfixes**
* #3279 Add some more randomness to chunk assignment
* #3288 Fix failed update with parallel workers
* #3300 Improve trigger handling on distributed hypertables
* #3304 Remove paths that reference parent relids for compressed chunks
* #3305 Fix pull_varnos miscomputation of relids set
* #3310 Generate downgrade script
* #3314 Fix heap buffer overflow in hypertable expansion
* #3317 Fix heap buffer overflow in remote connection cache.
* #3327 Make aggregate in caggs fully qualified
* #3327 Make aggregates in caggs fully qualified
* #3336 Fix pg_init_privs objsubid handling
* #3345 Fix SkipScan distinct column identification
* #3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* #3367 Improve DecompressChunk qual pushdown
* #3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 2, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 2, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 2, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 2, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading.

**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 5, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading.

**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 5, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading. The release introduces the
possibility of generating downgrade scripts, improves the trigger
handling for distributed hypertables, adds some more randomness to
chunk assignment to avoid thundering herd issues in chunk assignment,
and fixes some issues in update handling as well as some other bugs.

**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 5, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading. The release introduces the
possibility of generating downgrade scripts, improves the trigger
handling for distributed hypertables, adds some more randomness to
chunk assignment to avoid thundering herd issues in chunk assignment,
and fixes some issues in update handling as well as some other bugs.

**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit that referenced this pull request Jul 6, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading. The release introduces the
possibility of generating downgrade scripts, improves the trigger
handling for distributed hypertables, adds some more randomness to
chunk assignment to avoid thundering herd issues in chunk assignment,
and fixes some issues in update handling as well as some other bugs.

**Bugfixes**
* #3279 Add some more randomness to chunk assignment
* #3288 Fix failed update with parallel workers
* #3300 Improve trigger handling on distributed hypertables
* #3304 Remove paths that reference parent relids for compressed chunks
* #3305 Fix pull_varnos miscomputation of relids set
* #3310 Generate downgrade script
* #3314 Fix heap buffer overflow in hypertable expansion
* #3317 Fix heap buffer overflow in remote connection cache.
* #3327 Make aggregate in caggs fully qualified
* #3327 Make aggregates in caggs fully qualified
* #3336 Fix pg_init_privs objsubid handling
* #3345 Fix SkipScan distinct column identification
* #3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* #3367 Improve DecompressChunk qual pushdown
* #3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error during upgrade to 2.2.1
4 participants