Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG14 ModifyTablePath struct change #3631

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Oct 1, 2021

There are more changes required to adjust our code to the insert path changes but i pulled this PR out to keep the mechanical changes separate from the actual refactoring to make reviewing easier.

Disable-check: commit-count

@svenklemm svenklemm requested a review from a team as a code owner October 1, 2021 11:22
@svenklemm svenklemm requested review from afiskon, akuzm, mfundul, erimatnor, mkindahl and gayyappan and removed request for a team October 1, 2021 11:22
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #3631 (508fb3f) into master (98f4cd6) will not change coverage.
The diff coverage is 96.96%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3631   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files         212      212           
  Lines       36528    36528           
=======================================
  Hits        33168    33168           
  Misses       3360     3360           
Impacted Files Coverage Δ
src/import/allpaths.c 80.99% <ø> (ø)
src/nodes/chunk_dispatch_plan.c 100.00% <ø> (ø)
src/nodes/chunk_insert_state.c 97.76% <ø> (ø)
tsl/src/debug.c 40.21% <ø> (ø)
src/nodes/hypertable_insert.c 96.25% <93.75%> (-0.14%) ⬇️
src/copy.c 90.40% <100.00%> (ø)
src/hypertable.c 88.02% <100.00%> (ø)
src/nodes/chunk_dispatch.c 98.21% <100.00%> (ø)
src/nodes/chunk_dispatch_state.c 93.24% <100.00%> (+0.09%) ⬆️
src/plan_expand_hypertable.c 94.05% <100.00%> (+0.03%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4eb63...508fb3f. Read the comment docs.

@svenklemm svenklemm self-assigned this Oct 1, 2021
@svenklemm svenklemm added the pg14 label Oct 1, 2021
@svenklemm svenklemm added this to the TimescaleDB 2.5 milestone Oct 1, 2021
@svenklemm svenklemm force-pushed the pg14_mtpath_subpaths branch 2 times, most recently from 33f3f12 to c76f53a Compare October 1, 2021 13:17
Copy link
Contributor

@fabriziomello fabriziomello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svenklemm svenklemm force-pushed the pg14_mtpath_subpaths branch 12 times, most recently from d6e006a to f159e55 Compare October 3, 2021 22:16
@svenklemm svenklemm force-pushed the pg14_mtpath_subpaths branch 3 times, most recently from c54ad1a to f159e55 Compare October 4, 2021 00:54
@svenklemm svenklemm force-pushed the pg14_mtpath_subpaths branch 4 times, most recently from 5ce4c6f to 3be54ac Compare October 4, 2021 10:15
PG14 removes partitioned_child_rels from RelOptInfo

postgres/postgres@a929e17e
PG14 changes ModifyTablePath struct to have single child subpath
instead of list of subpaths. Similarly ModifyTableState mt_nplans
gets removed because ModifyTable will only have single child in
PG14. The same patch also removes ri_junkFilter from ResultRelInfo.

postgres/postgres@86dc9005
PG14 removes es_result_relation_info from executor state.

postgres/postgres@a04daa97
@svenklemm svenklemm merged commit f0ba729 into timescale:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants