Make dist_partial_agg output pg version specific #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
berkley,
pmwkaa and
mfundul
and removed request for
a team
svenklemm
force-pushed
the
pg14_dist_1
branch
from
b26ebd2
to
c421d30
Compare
svenklemm
requested review from
afiskon,
fabriziomello,
gayyappan and
nikkhils
svenklemm
force-pushed
the
pg14_dist_1
branch
from
c421d30
to
2ee343e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3682 +/- ##
==========================================
- Coverage 90.78% 90.77% -0.01%
==========================================
Files 212 212
Lines 36551 36533 -18
==========================================
- Hits 33182 33163 -19
- Misses 3369 3370 +1
Continue to review full report at Codecov.
|
mkindahl
approved these changes
Oct 13, 2021
afiskon
approved these changes
Oct 13, 2021
The plan output of the dist_partial_agg test is different on PG14 so we need to make it PG version specific. On PG14 sorts are pushed down more often leading to better plans in some cases. This also updates the dist_hypertable-14 test output which differs to previous PG versions due to some renumbering of relation aliases.
svenklemm
force-pushed
the
pg14_dist_1
branch
from
2ee343e
to
50af911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan output of the dist_partial_agg test is different on PG14
so we need to make it PG version specific. On PG14 sorts are pushed
down more often leading to better plans in some cases.