Use pass by reference in make_partfunc_call #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
erimatnor,
konskov,
gayyappan,
akuzm,
fabriziomello,
jnidzwetzki,
mfundul,
nikkhils and
pmwkaa
and removed request for
a team
mkindahl
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Sounds like this is only done to avoid the warning, not because it is actually a good idea. Suggest this wording:
Passing structures by value in function calls copies the entire structure, which is inefficient, so we switch it to pass by reference to reduce the amount of copying required.
src/planner/space_constraint.c
Outdated
| @@ -117,11 +117,11 @@ is_valid_scalar_space_constraint(ScalarArrayOpExpr *op, List *rtable) | |||
| } | |||
|
|
|||
| static FuncExpr * | |||
| make_partfunc_call(PartitioningFunc partfunc, List *args, Oid inputcollid) | |||
| make_partfunc_call(PartitioningFunc *partfunc, List *args, Oid inputcollid) | |||
There was a problem hiding this comment.
Since the intention is to only read the data, it is good to encode this in the signature.
Suggested change
| make_partfunc_call(PartitioningFunc *partfunc, List *args, Oid inputcollid) | |
| make_partfunc_call(const PartitioningFunc *partfunc, List *args, Oid inputcollid) |
Codecov Report
@@ Coverage Diff @@
## main #4438 +/- ##
=======================================
Coverage 90.85% 90.85%
=======================================
Files 221 221
Lines 40731 40731
=======================================
Hits 37006 37006
Misses 3725 3725
Continue to review full report at Codecov.
|
fabriziomello
approved these changes
Jun 13, 2022
svenklemm
force-pushed
the
coverity_pass_by_value
branch
from
769f7dc
to
a953c71
Compare
Refactor make_partfunc_call to only accept fnoid and rettype instead of PartitioningFunc which also gets rid of a coverity warning about that parameter being passed by value instead of reference because that parameter was longer than 128 bytes.
svenklemm
force-pushed
the
coverity_pass_by_value
branch
from
a953c71
to
0c8824b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity warned about usage of pass by value in this instance so
we switch it to pass by reference to reduce the amount of copying
required for the function call.