Better superuser handling for move_chunk #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkhils
force-pushed
the
ts/move-super
branch
3 times, most recently
from
57da44a
to
6e4a254
Compare
Codecov Report
@@ Coverage Diff @@
## main #4469 +/- ##
==========================================
- Coverage 90.79% 90.76% -0.03%
==========================================
Files 221 221
Lines 41003 41006 +3
==========================================
- Hits 37228 37219 -9
- Misses 3775 3787 +12
Continue to review full report at Codecov.
|
pmwkaa
approved these changes
Jun 27, 2022
Yes. This is an existing test with |
erimatnor
reviewed
Jun 27, 2022
The current code was assuming the bootstrap superuser for the actual move chunk operation. However, we can make it further flexible by using the logged in credentials if those happen to have superuser privileges.
erimatnor
approved these changes
Jun 27, 2022
Merged
mkindahl
added a commit
that referenced
this pull request
Jul 7, 2022
This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4494 Handle timescaledb versions aptly in multinode * #4493 Segfault when executing IMMUTABLE functions * #4482 Fix race conditions during chunk (de)compression * #4367 Improved buffer management in the copy operator * #4375 Don't ask for orderby column if default already set * #4400 Use our implementation of `find_em_expr_for_rel` for PG15+ * #4408 Fix crash during insert into distributed hypertable * #4411 Add `shmem_request_hook` * #4437 Fix segfault in subscription_exec * #4442 Fix perms in copy/move chunk * #4450 Retain hypertable ownership on `attach_data_node` * #4451 Repair numeric partial state on the fly * #4463 Fix empty bytea handlng with distributed tables * #4469 Better superuser handling for `move_chunk` **Features** * #4244 Function telemetry * #4287 Add internal api for foreign table chunk * #4470 Block drop chunk if chunk is in frozen state * #4464 Add internal api to associate a hypertable with custom jobs **Thanks** * @xin-hedera Finding bug in empty bytea values for distributed tables * @jflambert for reporting a bug with IMMUTABLE functions * @nikugogoi for reporting a bug with CTEs and upserts on distributed hypertables
mkindahl
added a commit
that referenced
this pull request
Jul 7, 2022
This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4494 Handle timescaledb versions aptly in multinode * #4493 Segfault when executing IMMUTABLE functions * #4482 Fix race conditions during chunk (de)compression * #4367 Improved buffer management in the copy operator * #4375 Don't ask for orderby column if default already set * #4400 Use our implementation of `find_em_expr_for_rel` for PG15+ * #4408 Fix crash during insert into distributed hypertable * #4411 Add `shmem_request_hook` * #4437 Fix segfault in subscription_exec * #4442 Fix perms in copy/move chunk * #4450 Retain hypertable ownership on `attach_data_node` * #4451 Repair numeric partial state on the fly * #4463 Fix empty bytea handlng with distributed tables * #4469 Better superuser handling for `move_chunk` **Features** * #4244 Function telemetry * #4287 Add internal api for foreign table chunk * #4470 Block drop chunk if chunk is in frozen state * #4464 Add internal api to associate a hypertable with custom jobs **Thanks** * @xin-hedera Finding bug in empty bytea values for distributed tables * @jflambert for reporting a bug with IMMUTABLE functions * @nikugogoi for reporting a bug with CTEs and upserts on distributed hypertables
mkindahl
added a commit
that referenced
this pull request
Jul 7, 2022
This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4494 Handle timescaledb versions aptly in multinode * #4493 Segfault when executing IMMUTABLE functions * #4482 Fix race conditions during chunk (de)compression * #4367 Improved buffer management in the copy operator * #4375 Don't ask for orderby column if default already set * #4400 Use our implementation of `find_em_expr_for_rel` for PG15+ * #4408 Fix crash during insert into distributed hypertable * #4411 Add `shmem_request_hook` * #4437 Fix segfault in subscription_exec * #4442 Fix perms in copy/move chunk * #4450 Retain hypertable ownership on `attach_data_node` * #4451 Repair numeric partial state on the fly * #4463 Fix empty bytea handlng with distributed tables * #4469 Better superuser handling for `move_chunk` **Features** * #4244 Function telemetry * #4287 Add internal api for foreign table chunk * #4470 Block drop chunk if chunk is in frozen state * #4464 Add internal api to associate a hypertable with custom jobs **Thanks** * @xin-hedera Finding bug in empty bytea values for distributed tables * @jflambert for reporting a bug with IMMUTABLE functions * @nikugogoi for reporting a bug with CTEs and upserts on distributed hypertables
mkindahl
added a commit
that referenced
this pull request
Jul 7, 2022
This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4494 Handle timescaledb versions aptly in multinode * #4493 Segfault when executing IMMUTABLE functions * #4482 Fix race conditions during chunk (de)compression * #4367 Improved buffer management in the copy operator * #4375 Don't ask for orderby column if default already set * #4400 Use our implementation of `find_em_expr_for_rel` for PG15+ * #4408 Fix crash during insert into distributed hypertable * #4411 Add `shmem_request_hook` * #4437 Fix segfault in subscription_exec * #4442 Fix perms in copy/move chunk * #4450 Retain hypertable ownership on `attach_data_node` * #4451 Repair numeric partial state on the fly * #4463 Fix empty bytea handlng with distributed tables * #4469 Better superuser handling for `move_chunk` **Features** * #4244 Function telemetry * #4287 Add internal api for foreign table chunk * #4470 Block drop chunk if chunk is in frozen state * #4464 Add internal api to associate a hypertable with custom jobs **Thanks** * @xin-hedera Finding bug in empty bytea values for distributed tables * @jflambert for reporting a bug with IMMUTABLE functions * @nikugogoi for reporting a bug with CTEs and upserts on distributed hypertables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code was assuming the bootstrap superuser for the actual
move chunk operation. However, we can make it further flexible by using
the logged in credentials if those happen to have superuser privileges.