Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pgspot update script check #4701

Merged
merged 1 commit into from Sep 14, 2022

Conversation

svenklemm
Copy link
Member

Previously the pgspot call used in CI did not properly check the update script. Unsafe function creations for functions with changed signatures could go undetected in the update script.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #4701 (cd14666) into main (a26a597) will decrease coverage by 0.03%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4701      +/-   ##
==========================================
- Coverage   90.82%   90.78%   -0.04%     
==========================================
  Files         224      224              
  Lines       42344    42402      +58     
==========================================
+ Hits        38457    38496      +39     
- Misses       3887     3906      +19     
Impacted Files Coverage Δ
src/chunk.h 100.00% <ø> (ø)
src/compat/compat.h 92.98% <87.50%> (-2.14%) ⬇️
src/hypertable_restrict_info.c 94.84% <94.59%> (-1.01%) ⬇️
src/chunk_scan.c 98.47% <98.73%> (+2.61%) ⬆️
src/chunk.c 95.19% <100.00%> (+0.09%) ⬆️
src/hypertable.c 87.07% <100.00%> (+0.23%) ⬆️
src/planner/constify_now.c 98.90% <100.00%> (+0.10%) ⬆️
src/planner/expand_hypertable.c 93.94% <100.00%> (-0.03%) ⬇️
src/bgw/job_stat.c 86.85% <0.00%> (-3.29%) ⬇️
src/loader/bgw_message_queue.c 85.52% <0.00%> (-2.64%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b36818...cd14666. Read the comment docs.

@svenklemm svenklemm self-assigned this Sep 13, 2022
Previously the pgspot call used in CI did not properly check the
update script. Unsafe function creations for functions with changed
signatures could go undetected in the update script.
@svenklemm svenklemm enabled auto-merge (rebase) September 14, 2022 13:42
@svenklemm svenklemm merged commit 063bfcf into timescale:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants