Enable -Wextra #4875
Merged
Enable -Wextra #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4875 +/- ##
==========================================
- Coverage 89.50% 89.46% -0.04%
==========================================
Files 225 225
Lines 50191 50189 -2
==========================================
- Hits 44923 44904 -19
- Misses 5268 5285 +17
Continue to review full report at Codecov.
|
akuzm
commented
Oct 25, 2022
| @@ -1466,7 +1466,7 @@ Datum | |||
| tsl_compressed_data_recv(PG_FUNCTION_ARGS) | |||
| { | |||
| StringInfo buf = (StringInfo) PG_GETARG_POINTER(0); | |||
| CompressedDataHeader header = { { 0 } }; | |||
| CompressedDataHeader header = { .vl_len_ = { 0 } }; | |||
There was a problem hiding this comment.
clang-15 with -Wextra doesn't like double nested braces, and gcc 4.8.5 doesn't like single braces, so this is how we have to compromise to avoid warnings
Also see this PR https://github.com/timescale/timescaledb/pull/4867/files#r1004751330
|
Doesn't introduce new warnings on gcc 4.8.5 as of ab0e3ca |
svenklemm
approved these changes
Oct 25, 2022
jnidzwetzki
approved these changes
Oct 27, 2022
Our code mostly has warnings about comparison with different signedness.
It's not something we normally do for the developer tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code mostly has warnings about assignment/comparison of int types of different signedness.
Disable-check: commit-count