Honor usage of OidIsValid() macro #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
use_oidisvalid_macro_instead_of_invalidoid_comparison
branch
from
5f65b16
to
77986f2
Compare
jnidzwetzki
approved these changes
Nov 2, 2022
svenklemm
approved these changes
Nov 2, 2022
fabriziomello
added
tech-debt
fabriziomello
force-pushed
the
use_oidisvalid_macro_instead_of_invalidoid_comparison
branch
3 times, most recently
from
06c651f
to
baec18c
Compare
Codecov Report
@@ Coverage Diff @@
## main #4908 +/- ##
===========================================
- Coverage 89.50% 63.04% -26.47%
===========================================
Files 225 226 +1
Lines 50238 44682 -5556
===========================================
- Hits 44968 28168 -16800
- Misses 5270 16514 +11244
Continue to review full report at Codecov.
|
fabriziomello
force-pushed
the
use_oidisvalid_macro_instead_of_invalidoid_comparison
branch
2 times, most recently
from
f822815
to
c24619e
Compare
fabriziomello
force-pushed
the
use_oidisvalid_macro_instead_of_invalidoid_comparison
branch
from
c24619e
to
81fc8ad
Compare
Postgres source code define the macro `OidIsValid()` to check if the Oid is valid or not (comparing against the `InvalidOid` type). See `src/include/c.h` in Postgres source three. Changed all direct comparisons against `InvalidOid` for the `OidIsValid` call and add a coccinelle check to make sure the future changes will use it correctly.
fabriziomello
force-pushed
the
use_oidisvalid_macro_instead_of_invalidoid_comparison
branch
from
81fc8ad
to
2ef09cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres source code define the macro
OidIsValid()to check if the Oid is valid or not (comparing against theInvalidOidtype). Seesrc/include/c.hin Postgres source three.Changed all direct comparisons against
InvalidOidfor theOidIsValidcall and add a coccinelle check to make sure the future changes will use it correctly.