Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL test files to trailing whitespace CI check #4989

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Nov 16, 2022

In commit 1f80715 we added a CI check for trailing whitespaces over
our source code files (.c and .h).

This commit add SQL test files (.sql and .sql.in) to this check.

disable-check: commit-count

@fabriziomello fabriziomello self-assigned this Nov 16, 2022
@fabriziomello fabriziomello force-pushed the add_test_files_to_trailing_whitespace_check branch 3 times, most recently from 02caf38 to df95b51 Compare November 16, 2022 21:56
@fabriziomello fabriziomello force-pushed the add_test_files_to_trailing_whitespace_check branch from df95b51 to d164c61 Compare November 18, 2022 15:30
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #4989 (c9fd6a1) into main (33e4e55) will decrease coverage by 1.30%.
The diff coverage is 88.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4989      +/-   ##
==========================================
- Coverage   90.99%   89.69%   -1.31%     
==========================================
  Files         224      226       +2     
  Lines       42586    51124    +8538     
==========================================
+ Hits        38751    45855    +7104     
- Misses       3835     5269    +1434     
Impacted Files Coverage Δ
src/chunk.h 100.00% <ø> (ø)
src/chunk_index.h 100.00% <ø> (ø)
src/compat/compat.h 58.82% <ø> (-34.16%) ⬇️
src/dimension_vector.c 87.50% <0.00%> (+1.13%) ⬆️
src/loader/bgw_message_queue.c 89.20% <ø> (+1.04%) ⬆️
src/nodes/chunk_append/planner.c 93.08% <ø> (-0.82%) ⬇️
src/nodes/hypertable_modify.c 35.78% <0.00%> (-34.51%) ⬇️
src/planner/planner.h 100.00% <ø> (ø)
src/ts_catalog/catalog.h 100.00% <ø> (ø)
src/ts_catalog/continuous_agg.h 100.00% <ø> (ø)
... and 301 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3749953...c9fd6a1. Read the comment docs.

@fabriziomello fabriziomello force-pushed the add_test_files_to_trailing_whitespace_check branch 2 times, most recently from 407a845 to ea64679 Compare November 18, 2022 16:01
In commit 1f80715 we added a CI check for trailing whitespaces over
our source code files (.c and .h).

This commit add SQL test files (.sql and .sql.in) to this check.
@fabriziomello fabriziomello force-pushed the add_test_files_to_trailing_whitespace_check branch from ea64679 to 210df95 Compare November 18, 2022 17:54
@fabriziomello fabriziomello added ci enhancement An enhancement to an existing feature for functionality Team: Core Database labels Nov 18, 2022
@fabriziomello fabriziomello force-pushed the add_test_files_to_trailing_whitespace_check branch from 210df95 to c9fd6a1 Compare November 18, 2022 18:11
@fabriziomello fabriziomello merged commit a4356f3 into timescale:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement An enhancement to an existing feature for functionality Team: Core Database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants