Add a GUC variable to enable/disable OSM reads #4991
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## main #4991 +/- ##
==========================================
- Coverage 89.61% 89.59% -0.03%
==========================================
Files 227 227
Lines 51608 51617 +9
==========================================
- Hits 46251 46248 -3
- Misses 5357 5369 +12
Continue to review full report at Codecov.
|
zilder
force-pushed
the
zilder/osm_guc
branch
2 times, most recently
from
a6ddda1
to
93bbc60
Compare
src/hypertable_restrict_info.c
Outdated
| chunk_ids = !ts_guc_enable_osm_reads ? list_delete_int(chunk_ids, osm_chunk_id) : | ||
| !list_member_int(chunk_ids, osm_chunk_id) ? | ||
| lappend_int(chunk_ids, osm_chunk_id) : | ||
| chunk_ids; |
There was a problem hiding this comment.
I am surprised we have a code cov issue here. Could you take a look?
There was a problem hiding this comment.
I rewrote it into an if/else statement after Jan's suggestion. Codecov now complains about the closing braces, but I don't think I can do anything about it.
zilder
force-pushed
the
zilder/osm_guc
branch
from
93bbc60
to
4fe69b5
Compare
zilder
force-pushed
the
zilder/osm_guc
branch
2 times, most recently
from
ba902de
to
358133f
Compare
src/hypertable_restrict_info.c
Outdated
| { | ||
| chunk_ids = list_delete_int(chunk_ids, osm_chunk_id); | ||
| } | ||
| else if (!list_member_int(chunk_ids, osm_chunk_id)) |
There was a problem hiding this comment.
Nit: list_append_unique_int could be an alternative
There was a problem hiding this comment.
Oh, I missed that function. Thanks for the review!
zilder
force-pushed
the
zilder/osm_guc
branch
from
358133f
to
7989eb2
Compare
zilder
force-pushed
the
zilder/osm_guc
branch
from
7989eb2
to
9c401aa
Compare
The GUC variable controls whether OSM chunk is used in a select query plan.