Use fixed alpine version for upgrade/downgrade tests #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SachinSetiya
force-pushed
the
downgrade-fix
branch
from
417cabb
to
64353e3
Compare
Codecov Report
@@ Coverage Diff @@
## main #5043 +/- ##
==========================================
- Coverage 89.64% 89.59% -0.05%
==========================================
Files 227 227
Lines 51616 51593 -23
==========================================
- Hits 46270 46225 -45
- Misses 5346 5368 +22
Continue to review full report at Codecov.
|
SachinSetiya
force-pushed
the
downgrade-fix
branch
7 times, most recently
from
8ad5b81
to
838f2fb
Compare
fabriziomello
approved these changes
Dec 1, 2022
SachinSetiya
force-pushed
the
downgrade-fix
branch
from
70b69c3
to
3ee8a0a
Compare
jnidzwetzki
approved these changes
Dec 2, 2022
lkshminarayanan
approved these changes
Dec 2, 2022
Closed
SachinSetiya
force-pushed
the
downgrade-fix
branch
from
3ee8a0a
to
e775a13
Compare
lkshminarayanan
suggested changes
Dec 2, 2022
SachinSetiya
force-pushed
the
downgrade-fix
branch
from
a60565d
to
0e37fd9
Compare
lkshminarayanan
approved these changes
Dec 5, 2022
SachinSetiya
force-pushed
the
downgrade-fix
branch
from
1b1c9e2
to
778b478
Compare
SachinSetiya
force-pushed
the
downgrade-fix
branch
from
778b478
to
3095124
Compare
Not specifying alpine version causes libssl version to change, which in turn cause error in downgrade tests as well as ABI tests. This commit also fixes shellcheck failures. Some failing windows tests are addd to ignore list. Co-authored-by: Lakshmi Narayanan Sreethar <lakshmi@timescale.com> Co-authored-by: Alexander Kuzmenkov <akuzmenkov@timescale.com> Signed-off-by: Sachin <sachin@timescale.com>
SachinSetiya
force-pushed
the
downgrade-fix
branch
from
3095124
to
7c1929d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating alpine version causes libssl version to change, which in turn cause error in downgrade tests.