Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure chunk_dispatch #5169

Merged
merged 1 commit into from Jan 10, 2023

Conversation

svenklemm
Copy link
Member

This patch adjusts the code layout for chunk_dispatch to be similar to the other custom nodes. All the files related to chunk_dispatch are moved into dedicated nodes/chunk_dispatch directory.

@github-actions
Copy link

@mkindahl, @jnidzwetzki: please review this pull request.

Powered by pull-review

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #5169 (a8dfa65) into main (2c70dc6) will increase coverage by 0.09%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5169      +/-   ##
==========================================
+ Coverage   89.47%   89.56%   +0.09%     
==========================================
  Files         227      225       -2     
  Lines       51615    51535      -80     
==========================================
- Hits        46180    46157      -23     
+ Misses       5435     5378      -57     
Impacted Files Coverage Δ
src/copy.c 91.76% <ø> (+1.28%) ⬆️
src/nodes/hypertable_modify.c 35.78% <ø> (ø)
src/planner/planner.c 96.04% <ø> (+0.13%) ⬆️
tsl/src/fdw/modify_exec.c 85.55% <ø> (+0.32%) ⬆️
tsl/src/nodes/data_node_copy.c 92.35% <ø> (ø)
tsl/src/nodes/data_node_dispatch.c 93.24% <ø> (ø)
tsl/src/remote/dist_copy.c 88.79% <ø> (ø)
src/nodes/chunk_dispatch/chunk_dispatch.c 94.26% <94.26%> (ø)
src/nodes/chunk_dispatch/chunk_insert_state.c 97.57% <100.00%> (ø)
src/loader/bgw_launcher.c 89.51% <0.00%> (-2.55%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c70dc6...a8dfa65. Read the comment docs.

@svenklemm svenklemm force-pushed the chunk_dispatch_restructure branch 2 times, most recently from a820133 to f62da63 Compare January 10, 2023 12:57
This patch adjusts the code layout for chunk_dispatch to be similar
to the other custom nodes. All the files related to chunk_dispatch
are moved into dedicated nodes/chunk_dispatch directory.
@svenklemm svenklemm enabled auto-merge (rebase) January 10, 2023 15:39
@svenklemm svenklemm merged commit cfd34f2 into timescale:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants