Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scan plan logic for remote joins #5196

Merged
merged 1 commit into from Jan 23, 2023

Conversation

jnidzwetzki
Copy link
Member

This patch adds the missing functionality to create scan plans for remote joins. Most of the code is a backport from PG Upstream.

@jnidzwetzki jnidzwetzki marked this pull request as ready for review January 18, 2023 13:55
Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This patch adds the missing functionality to create scan plans for
remote joins. Most of the code is a backport from PG Upstream.
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #5196 (2a042c3) into main (f211294) will decrease coverage by 26.40%.
The diff coverage is 34.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5196       +/-   ##
===========================================
- Coverage   89.04%   62.64%   -26.40%     
===========================================
  Files         225      225               
  Lines       51752    45396     -6356     
===========================================
- Hits        46084    28440    -17644     
- Misses       5668    16956    +11288     
Impacted Files Coverage Δ
tsl/src/fdw/fdw.c 51.02% <0.00%> (-43.19%) ⬇️
tsl/src/fdw/scan_plan.c 86.39% <33.33%> (-5.04%) ⬇️
tsl/src/fdw/data_node_scan_plan.c 96.73% <100.00%> (-0.42%) ⬇️
src/chunk.h 0.00% <0.00%> (-100.00%) ⬇️
src/chunk_index.h 0.00% <0.00%> (-100.00%) ⬇️
tsl/src/remote/data_fetcher.h 0.00% <0.00%> (-100.00%) ⬇️
tsl/src/compression/dictionary_hash.h 0.00% <0.00%> (-100.00%) ⬇️
tsl/src/compression/simple8b_rle.h 0.00% <0.00%> (-96.57%) ⬇️
src/scanner.c 0.00% <0.00%> (-94.10%) ⬇️
src/loader/bgw_counter.c 0.00% <0.00%> (-87.04%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f211294...2a042c3. Read the comment docs.

@jnidzwetzki jnidzwetzki merged commit 9ae3ae3 into timescale:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants