Fix use of prepared statement in async module #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
force-pushed
the
fix-use-of-async-prepared-statement
branch
from
af91ef1
to
2144aa3
Compare
Codecov Report
@@ Coverage Diff @@
## main #5214 +/- ##
==========================================
- Coverage 89.01% 89.01% -0.01%
==========================================
Files 225 225
Lines 51786 51823 +37
==========================================
+ Hits 46099 46131 +32
- Misses 5687 5692 +5
Continue to review full report at Codecov.
|
erimatnor
force-pushed
the
fix-use-of-async-prepared-statement
branch
from
2144aa3
to
dbf451c
Compare
erimatnor
requested review from
nikkhils,
pmwkaa,
65278,
jnidzwetzki and
akuzm
erimatnor
commented
Jan 25, 2023
| @@ -162,6 +164,16 @@ async_request_send_internal(AsyncRequest *req, int elevel) | |||
| remote_connection_configure_if_changed(req->conn); | |||
|
|
|||
| if (req->stmt_name) | |||
| { | |||
| ret = PQsendQueryPrepared(remote_connection_get_pg_conn(req->conn), | |||
There was a problem hiding this comment.
PQsendQueryPrepared() didn't exist in our code, so prepared statements were never executed.
pmwkaa
approved these changes
Jan 25, 2023
It is already tested by existing tests. You can see in CodeCov that the code path for the new libpq call is covered (except for some error handling cases that in practice don't happen). |
jnidzwetzki
reviewed
Jan 27, 2023
erimatnor
force-pushed
the
fix-use-of-async-prepared-statement
branch
from
dbf451c
to
3731a5b
Compare
erimatnor
force-pushed
the
fix-use-of-async-prepared-statement
branch
from
3731a5b
to
ec24cd9
Compare
jnidzwetzki
approved these changes
Jan 31, 2023
Broken code caused the async connection module to never send queries using prepared statements. Instead, queries were sent using the parameterized query statement instead. Fix this so that prepared statements are used when created.
erimatnor
force-pushed
the
fix-use-of-async-prepared-statement
branch
from
ec24cd9
to
da1d5b8
Compare
Merged
mahipv
added a commit
that referenced
this pull request
Feb 20, 2023
This release contains new features and bug fixes since the 2.9.3 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Features** * #5241 Allow RETURNING clause when inserting into compressed chunks * #5245 Manage life-cycle of connections via memory contexts * #5246 Make connection establishment interruptible * #5253 Make data node command execution interruptible * #5243 Enable real-time aggregation for continuous aggregates with joins * #5262 Extend enabling compression on a continuous aggregrate with 'compress_segmentby' and 'compress_orderby' parameters **Bugfixes** * #4926 Fix corruption when inserting into compressed chunks * #5218 Add role-level security to job error log * #5214 Fix use of prepared statement in async module * #5290 Compression can't be enabled on continuous aggregates when segmentby/orderby columns need quotation * #5239 Fix next_start calculation for fixed schedules
mahipv
pushed a commit
that referenced
this pull request
Feb 21, 2023
This release contains new features and bug fixes since the 2.9.3 release. We deem it moderate priority for upgrading. This release includes these noteworthy features: * Joins in continuous aggregates * Re-architecture of how compression works: ~2x improvement on INSERT rate into compressed chunks. * Full PostgreSQL 15 support for all existing features. Support for the newly introduced MERGE command on hypertables will be introduced on a follow-up release. **PostgreSQL 12 deprecation announcement** We will continue supporting PostgreSQL 12 until July 2023. Sooner to that time, we will announce the specific version of TimescaleDB in which PostgreSQL 12 support will not be included going forward. **Old format of Continuous Aggregates deprecation announcement** TimescaleDB 2.7 introduced a new format for continuous aggregates that improves performance. All instances with Continuous Aggregates using the old format should [migrate to the new format](https://docs.timescale.com/api/latest/continuous-aggregates/cagg_migrate/) by July 2023, when support for the old format will be removed. Sooner to that time, we will announce the specific version of TimescaleDB in which support for this feature will not be included going forward. **Features** * #4874 Allow joins in continuous aggregates * #4926 Refactor INSERT into compressed chunks * #5241 Allow RETURNING clause when inserting into compressed chunks * #5245 Manage life-cycle of connections via memory contexts * #5246 Make connection establishment interruptible * #5253 Make data node command execution interruptible * #5262 Extend enabling compression on a continuous aggregrate with 'compress_segmentby' and 'compress_orderby' parameters **Bugfixes** * #5214 Fix use of prepared statement in async module * #5218 Add role-level security to job error log * #5239 Fix next_start calculation for fixed schedules * #5290 Fix enabling compression on continuous aggregates with columns requiring quotation **Thanks** * @henriquegelio for reporting the issue on fixed schedules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken code caused the async connection module to never send queries
using prepared statements. Instead, queries were sent using the
parameterized query statement instead.
The regression was introduced a long time ago in commit 86858e3
Fix this so that prepared statements are used when created.