Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change usage of term nested to hierarchical #5347

Merged

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Feb 17, 2023

To don't make developers confused the right name for Continuous Aggregates on top of another Continuous Aggregates is Hierarchical Continuous Aggregates, so changed the usage of term nested for hierarchical.

Disable-check: force-changelog-changed

To don't make developers confused the right name for Continuous
Aggregates on top of another Continuous Aggregates is `Hierarchical
Continuous Aggregates`, so changed the usage of term `nested` for
`hierarchical`.
@github-actions
Copy link

@mkindahl, @konskov: please review this pull request.

Powered by pull-review

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #5347 (81965ad) into main (d50de8a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5347      +/-   ##
==========================================
- Coverage   90.71%   90.67%   -0.04%     
==========================================
  Files         225      225              
  Lines       52018    52013       -5     
==========================================
- Hits        47187    47164      -23     
- Misses       4831     4849      +18     
Impacted Files Coverage Δ
src/ts_catalog/continuous_agg.h 100.00% <100.00%> (ø)
tsl/src/continuous_aggs/create.c 89.10% <100.00%> (ø)
src/bgw/scheduler.c 84.39% <0.00%> (-4.10%) ⬇️
src/loader/bgw_message_queue.c 86.36% <0.00%> (-2.28%) ⬇️
tsl/src/reorder.c 85.49% <0.00%> (-0.22%) ⬇️
src/bgw/job.c 93.24% <0.00%> (-0.17%) ⬇️
tsl/src/bgw_policy/job.c 87.45% <0.00%> (-0.05%) ⬇️
src/compat/compat.h 96.61% <0.00%> (+6.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fabriziomello fabriziomello enabled auto-merge (rebase) February 18, 2023 13:51
@fabriziomello fabriziomello merged commit c7f4639 into timescale:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants