Renamed size_utils.sql #5368
Merged
Renamed size_utils.sql #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akuzm
approved these changes
Feb 28, 2023
Agree that the current renaming is a bit confusing but would like to simplify a bit it: |
fabriziomello
approved these changes
Mar 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #5368 +/- ##
==========================================
- Coverage 90.69% 90.68% -0.02%
==========================================
Files 226 226
Lines 52522 52519 -3
==========================================
- Hits 47635 47627 -8
- Misses 4887 4892 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jnidzwetzki
approved these changes
Mar 2, 2023
Renamed: tsl/test/sql/size_utils.sql tsl/test/expected/size_utils.out To: tsl/test/sql/size_utils_tsl.sql tsl/test/expected/size_utils_tsl.out because conflicting with test/sql/size_utils.sql
|
@akuzm, @mkindahl: please review this pull request.
|
mkindahl
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed test/sql/size_utils.sql
to test/sql/utils_size.sql
because conflicting with tsl/test/sql/size_utils.sql