Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license information to extension description #5440

Merged
merged 1 commit into from Mar 20, 2023
Merged

Add license information to extension description #5440

merged 1 commit into from Mar 20, 2023

Conversation

konskov
Copy link
Contributor

@konskov konskov commented Mar 14, 2023 •
edited

Fixes #5436

@konskov konskov changed the title Show license version in \dx Add license information to extension description Mar 14, 2023
@konskov konskov marked this pull request as ready for review March 14, 2023 14:11
@github-actions
Copy link

@mahipv, @fabriziomello: please review this pull request.

Powered by pull-review

svenklemm
svenklemm reviewed Mar 15, 2023
View reviewed changes
timescaledb.control.in Outdated
@@ -1,5 +1,5 @@
# timescaledb extension
comment = 'Enables scalable inserts and complex queries for time-series data'
comment = '(@LICENSE_EDITION@) Enables scalable inserts and complex queries for time-series data'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i would prefer this being suffix instead of prefix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added as prefix because this was a suggestion by product: #5436 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think a suffix would be easier to read (cc @iroussos).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it as a prefix because I was afraid that the information would get lost. If you think that a suffix is better, then go with that one :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the information as suffix then.

@konskov konskov force-pushed the update_license_info_desc branch 3 times, most recently from a43d6e4 to b8a7830 Compare March 17, 2023 15:37
@konskov konskov force-pushed the update_license_info_desc branch 2 times, most recently from b6356fb to 42d84be Compare March 17, 2023 15:45
@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited

Codecov Report

Merging #5440 (53e9c41) into main (2570ab1) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 53e9c41 differs from pull request most recent head b7f2366. Consider uploading reports for the commit b7f2366 to get more accurate results

@@            Coverage Diff             @@
##             main    #5440      +/-   ##
==========================================
+ Coverage   90.72%   90.85%   +0.12%     
==========================================
  Files         228      228              
  Lines       53094    46737    -6357     
==========================================
- Hits        48171    42462    -5709     
+ Misses       4923     4275     -648

see 203 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fabriziomello fabriziomello enabled auto-merge (rebase) March 18, 2023 16:02
@fabriziomello fabriziomello merged commit 8cccc37 into timescale:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iroussos iroussos iroussos left review comments

@jnidzwetzki jnidzwetzki jnidzwetzki approved these changes

@svenklemm svenklemm svenklemm approved these changes

@fabriziomello fabriziomello Awaiting requested review from fabriziomello

@mahipv mahipv Awaiting requested review from mahipv

Assignees

@konskov konskov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add license information on the extension description
5 participants
@konskov @jnidzwetzki @iroussos @svenklemm @fabriziomello