Hardcode PG14-15 versions for chocolatey #5496
Conversation
|
@mkindahl, @jnidzwetzki: please review this pull request.
|
| pkg_version: ${{ fromJson(needs.config.outputs.pg14_latest) }} | ||
| # pkg_version: ${{ fromJson(needs.config.outputs.pg14_latest) }} | ||
| pkg_version: 14.5.1 # hardcoded due to issues with PG14.6 on chocolatey | ||
| tsl_skips_version: dist_partial_agg-14 dist_grant-14 | ||
| - pg: 15 | ||
| pkg_version: ${{ fromJson(needs.config.outputs.pg15_latest) }} | ||
| # pkg_version: ${{ fromJson(needs.config.outputs.pg15_latest) }} | ||
| pkg_version: 15.0.1 # hardcoded due to issues with PG15.1 on chocolatey |
There was a problem hiding this comment.
Isn't there a risk that we will forget fixing the issue and enabling the test again?
An alternative approach is to make the hardcoded version required but keep the existing test, but make it non-required. Then it will show up read in each push as a reminder that it's not done.
There was a problem hiding this comment.
I'm not sure about these details myself, just trying to backport the fix Konstantina did for main branch into the 2.10.x branch, so that I can release 2.10.2 this week.
Codecov Report
@@ Coverage Diff @@
## 2.10.x #5496 +/- ##
=========================================
Coverage ? 90.69%
=========================================
Files ? 226
Lines ? 52070
Branches ? 0
=========================================
Hits ? 47225
Misses ? 4845
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Backport of 736c20f #5467