Warn if result of ts_set_flags_32 is not used #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ts_set_flags_32 function takes a bitmap and flags and returns an updated bitmap. However, if the returned value is not used, the function call has no effect. An unused result may indicate the improper use of this function. This patch adds the qualifier pg_nodiscard to the function which triggers a warning if the returned value is not used.
|
@konskov, @pmwkaa: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #5856 +/- ##
==========================================
- Coverage 87.87% 80.37% -7.51%
==========================================
Files 239 239
Lines 55742 49014 -6728
Branches 12350 12289 -61
==========================================
- Hits 48985 39396 -9589
+ Misses 4864 4217 -647
- Partials 1893 5401 +3508
... and 222 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akuzm
reviewed
Jul 4, 2023
Comment on lines
+172
to
175
| static inline pg_nodiscard uint32 | ||
| ts_set_flags_32(uint32 bitmap, uint32 flags) | ||
| { | ||
| return bitmap | flags; |
There was a problem hiding this comment.
Maybe we should just replace it with |=?
There was a problem hiding this comment.
I also thought about modifying the value directly. But then decided against it to have a function signature that is similar to other PostgreSQL functions like lappend().
There was a problem hiding this comment.
No, I mean, remove the function altogether. Anyway, with your change it's better.
akuzm
approved these changes
Jul 4, 2023
konskov
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ts_set_flags_32function takes a bitmap and flags and returns an updated bitmap. However, if the returned value is not used, the function call has no effect. An unused result may indicate the improper use of this function.This patch adds the qualifier
pg_nodiscardto the function which triggers a warning if the returned value is not used.Disable-check: force-changelog-file