Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached Chunk struct when considering compressed paths #5953

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Aug 10, 2023

Full catalog lookups for a Chunk are expensive, avoiding them speeds up the planning.

Disable-check: force-changelog-file

@akuzm akuzm marked this pull request as ready for review August 10, 2023 14:01
@github-actions
Copy link

@pmwkaa, @svenklemm: please review this pull request.

Powered by pull-review

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #5953 (1100ebb) into main (fb617e4) will decrease coverage by 0.53%.
The diff coverage is 88.88%.

❗ Current head 1100ebb differs from pull request most recent head cbe099e. Consider uploading reports for the commit cbe099e to get more accurate results

@@            Coverage Diff             @@
##             main    #5953      +/-   ##
==========================================
- Coverage   87.09%   86.57%   -0.53%     
==========================================
  Files         243      243              
  Lines       56018    55927      -91     
  Branches    12401    12365      -36     
==========================================
- Hits        48789    48417     -372     
- Misses       4891     5166     +275     
- Partials     2338     2344       +6     
Files Changed Coverage Δ
src/planner/planner.h 85.71% <ø> (ø)
tsl/src/fdw/data_node_chunk_assignment.c 90.62% <50.00%> (ø)
tsl/src/planner.c 90.64% <88.88%> (-0.38%) ⬇️
src/planner/expand_hypertable.c 89.03% <100.00%> (-0.13%) ⬇️
src/planner/planner.c 90.86% <100.00%> (ø)
tsl/src/fdw/relinfo.c 93.56% <100.00%> (+0.03%) ⬆️

... and 47 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tsl/src/planner.c Outdated Show resolved Hide resolved
Full catalog lookups for a Chunk are expensive, avoiding them speeds up
the planning.
@akuzm akuzm enabled auto-merge (rebase) August 15, 2023 11:46
@akuzm akuzm merged commit 04ce1bc into timescale:main Aug 15, 2023
36 of 37 checks passed
@akuzm akuzm deleted the cached-chunk branch August 15, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants