Don't look up entire Chunk struct for compressed chunks #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@konskov, @pmwkaa: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #5970 +/- ##
==========================================
+ Coverage 79.52% 87.00% +7.48%
==========================================
Files 243 243
Lines 49266 55974 +6708
Branches 12346 12385 +39
==========================================
+ Hits 39177 48702 +9525
- Misses 4225 4910 +685
+ Partials 5864 2362 -3502
... and 216 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
konskov
approved these changes
Aug 16, 2023
jnidzwetzki
reviewed
Aug 21, 2023
| @@ -72,7 +73,8 @@ static DecompressChunkPath *decompress_chunk_path_create(PlannerInfo *root, Comp | |||
| int parallel_workers, | |||
| Path *compressed_path); | |||
|
|
|||
| static void decompress_chunk_add_plannerinfo(PlannerInfo *root, CompressionInfo *info, Chunk *chunk, | |||
| static void decompress_chunk_add_plannerinfo(PlannerInfo *root, Hypertable *ht, | |||
There was a problem hiding this comment.
It seems the new Hypertable *ht parameter is not used in this function.
jnidzwetzki
approved these changes
Aug 21, 2023
It's not needed. Also add them to baserel cache.
akuzm
force-pushed
the
baserel-compressed
branch
from
f98eaf0
to
00b0e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed. Also add them to baserel cache.
Disable-check: force-changelog-file