Move get_create_command into _timescaledb_functions schema #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mahipv, @konskov: please review this pull request.
|
svenklemm
force-pushed
the
move_get_create_command
branch
from
06d3b04
to
b0edb38
Compare
Codecov Report
@@ Coverage Diff @@
## main #5973 +/- ##
=======================================
Coverage 87.00% 87.01%
=======================================
Files 243 243
Lines 56006 55960 -46
Branches 12403 12384 -19
=======================================
- Hits 48728 48692 -36
+ Misses 4936 4905 -31
- Partials 2342 2363 +21 see 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jnidzwetzki
approved these changes
Aug 21, 2023
To increase schema security we do not want to mix our own internal objects with user objects. Since chunks are created in the _timescaledb_internal schema our internal functions should live in a different dedicated schema. This patch make the necessary adjustments for the get_create_command function.
svenklemm
force-pushed
the
move_get_create_command
branch
from
b0edb38
to
84fe6df
Compare
konskov
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase schema security we do not want to mix our own internal objects with user objects. Since chunks are created in the _timescaledb_internal schema our internal functions should live in a different dedicated schema. This patch make the necessary adjustments for the get_create_command function.
Disable-check: force-changelog-file