Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move size_util functions to _timescaledb_functions schema #5995

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Aug 22, 2023

To increase schema security we do not want to mix our own internal objects with user objects. Since chunks are created in the _timescaledb_internal schema our internal functions should live in a different dedicated schema. This patch make the necessary adjustments for the following functions:

  • relation_size(regclass)
  • data_node_hypertable_info(name, name, name)
  • data_node_chunk_info(name, name, name)
  • hypertable_local_size(name, name)
  • hypertable_remote_size(name, name)
  • chunks_local_size(name, name)
  • chunks_remote_size(name, name)
  • range_value_to_pretty(bigint, regtype)
  • get_approx_row_count(regclass)
  • data_node_compressed_chunk_stats(name, name, name)
  • compressed_chunk_local_stats(name, name)
  • compressed_chunk_remote_stats(name, name)
  • indexes_local_size(name, name)
  • data_node_index_size(name, name, name)
  • indexes_remote_size(name, name, name)

Disable-check: force-changelog-file

To increase schema security we do not want to mix our own internal
objects with user objects. Since chunks are created in the
_timescaledb_internal schema our internal functions should live in
a different dedicated schema. This patch make the necessary
adjustments for the following functions:

- relation_size(regclass)
- data_node_hypertable_info(name, name, name)
- data_node_chunk_info(name, name, name)
- hypertable_local_size(name, name)
- hypertable_remote_size(name, name)
- chunks_local_size(name, name)
- chunks_remote_size(name, name)
- range_value_to_pretty(bigint, regtype)
- get_approx_row_count(regclass)
- data_node_compressed_chunk_stats(name, name, name)
- compressed_chunk_local_stats(name, name)
- compressed_chunk_remote_stats(name, name)
- indexes_local_size(name, name)
- data_node_index_size(name, name, name)
- indexes_remote_size(name, name, name)
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #5995 (86cc0a2) into main (3db6922) will decrease coverage by 7.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5995      +/-   ##
==========================================
- Coverage   86.98%   79.43%   -7.55%     
==========================================
  Files         243      243              
  Lines       56006    49084    -6922     
  Branches    12403    12291     -112     
==========================================
- Hits        48716    38991    -9725     
+ Misses       4951     4270     -681     
- Partials     2339     5823    +3484     
Files Changed Coverage Δ
tsl/src/dist_util.c 78.94% <ø> (-8.12%) ⬇️

... and 222 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@svenklemm svenklemm merged commit 183362e into timescale:main Aug 22, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants