Make up/downgrade test deterministic #6017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gayyappan, @svenklemm: please review this pull request.
|
svenklemm
approved these changes
Aug 29, 2023
mkindahl
approved these changes
Aug 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #6017 +/- ##
==========================================
+ Coverage 87.08% 87.14% +0.05%
==========================================
Files 243 243
Lines 55993 55947 -46
Branches 12398 12379 -19
==========================================
- Hits 48763 48754 -9
+ Misses 4886 4844 -42
- Partials 2344 2349 +5 see 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Two queries in post.continuous_aggs.v3.sql had no ORDER BY specification. Therefore, the query output was not deterministic. This patch adds the missing ORDER BY.
jnidzwetzki
force-pushed
the
up_downgrade_test
branch
from
b6fa909
to
e7feff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two queries in post.continuous_aggs.v3.sql had no ORDER BY specification. Therefore, the query output was not deterministic. This patch adds the missing ORDER BY.
Disable-check: force-changelog-file