Export is_decompress_chunk_path / is_gapfill_path #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnidzwetzki
force-pushed
the
gappfill_reuse
branch
from
d2e0f8b
to
6ef145f
Compare
|
@nikkhils, @svenklemm: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #6022 +/- ##
==========================================
- Coverage 81.22% 81.18% -0.05%
==========================================
Files 243 243
Lines 55969 55923 -46
Branches 12397 12378 -19
==========================================
- Hits 45460 45399 -61
- Misses 8178 8189 +11
- Partials 2331 2335 +4
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
approved these changes
Aug 29, 2023
|
Should we instead make the version from tsl/src/nodes/gapfill/gapfill_plan.c available which doesnt rely on string comparison to determine the type? |
|
@svenklemm I was also thinking about using this version. However, the version from the TSL code needs access to the |
mkindahl
approved these changes
Aug 31, 2023
This patch adds the 'ts_' prefix to the function names of is_decompress_chunk_path and is_gapfill_path and makes them available for use by other parts of TimescaleDB.
jnidzwetzki
force-pushed
the
gappfill_reuse
branch
from
6ef145f
to
2a7bf7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the 'ts_' prefix to the function names of is_decompress_chunk_path and is_gapfill_path and makes them available for use by other parts of TimescaleDB.
Disable-check: force-changelog-file