Move view creation in setup.repair inside if #6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the view was created outside the if, leading to an unexpected error when attempting to drop a dependency of the view in the extension upgrade script.
|
@jnidzwetzki, @RafiaSabih: please review this pull request.
|
svenklemm
approved these changes
Sep 7, 2023
jnidzwetzki
approved these changes
Sep 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #6052 +/- ##
==========================================
- Coverage 81.40% 81.33% -0.07%
==========================================
Files 243 243
Lines 55940 55936 -4
Branches 12385 12382 -3
==========================================
- Hits 45537 45496 -41
+ Misses 8084 8077 -7
- Partials 2319 2363 +44 see 44 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the view was created outside the if, leading to an unexpected error when attempting to drop a dependency of the view in the extension upgrade script.