Fix segfault in ts_chunk_attach_osm_table_chunk on old pg versions #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erimatnor, @akuzm: please review this pull request.
|
mkindahl
approved these changes
Sep 15, 2023
konskov
approved these changes
Sep 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #6073 +/- ##
==========================================
- Coverage 81.57% 81.50% -0.08%
==========================================
Files 246 246
Lines 56535 56533 -2
Branches 12519 12516 -3
==========================================
- Hits 46121 46079 -42
- Misses 8053 8089 +36
- Partials 2361 2365 +4
... and 43 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
On older postgres versions the printf functions will segfault on
printf("%s", NULL) so we add some extra-logic to catch this.
While the osm function is not useful on this older versions
this was nevertheless triggered in our CI and it would be an
easy way to produce a segfault on those older versions.
postgres/postgres@3779ac6
svenklemm
force-pushed
the
osm_segfault
branch
from
3aee427
to
0fb27d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older postgres versions the printf functions will segfault on printf("%s", NULL) so we add some extra-logic to catch this. While the osm function is not useful on this older versions this was nevertheless triggered in our CI and it would be an easy way to produce a segfault on those older versions.
postgres/postgres@3779ac6
Disable-check: force-changelog-file