Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing cost initialization #6074

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

jnidzwetzki
Copy link
Contributor

@jnidzwetzki jnidzwetzki commented Sep 15, 2023

The Sanitizer build found a missing memory initialization of the aggregation costs. This PR adds the missing initialization.


Disable-check: force-changelog-file

Failing CI run: https://github.com/timescale/timescaledb/actions/runs/6192216103/job/16824687929
Fixed CI run: https://github.com/timescale/timescaledb/actions/runs/6197194660/job/16825298034

The Sanitizer build found a missing memory initialization of the
aggregation costs. This PR adds the missing initialization.
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #6074 (6c34b00) into main (7fbaf2a) will decrease coverage by 0.07%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #6074      +/-   ##
==========================================
- Coverage   81.57%   81.51%   -0.07%     
==========================================
  Files         246      246              
  Lines       56535    56535              
  Branches    12519    12518       -1     
==========================================
- Hits        46120    46085      -35     
- Misses       8071     8082      +11     
- Partials     2344     2368      +24     
Files Changed Coverage Δ
src/planner/partialize.c 94.28% <0.00%> (-0.46%) ⬇️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jnidzwetzki jnidzwetzki merged commit c802c31 into timescale:main Sep 15, 2023
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants