Simplify extension tap test #6092
Conversation
|
@jnidzwetzki, @erimatnor: please review this pull request.
|
svenklemm
force-pushed
the
provecheck_fix
branch
2 times, most recently
from
bb7da53
to
8d45768
Compare
The extension tap test is very flakey and seems to fail very often with unhelpful error messages. This patch simplifies the test to make it more reliable.
svenklemm
force-pushed
the
provecheck_fix
branch
from
8d45768
to
0c820d5
Compare
Codecov Report
@@ Coverage Diff @@
## main #6092 +/- ##
==========================================
- Coverage 81.55% 81.46% -0.09%
==========================================
Files 246 246
Lines 56444 56667 +223
Branches 12483 12553 +70
==========================================
+ Hits 46032 46164 +132
- Misses 8059 8098 +39
- Partials 2353 2405 +52 see 56 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| diag 'Actual output was ' . Dumper($out) . "Did not match \"$pattern\"\n" | ||
| if !$okay; | ||
| return; | ||
| is($result, $pattern, $annotation); |
There was a problem hiding this comment.
if I understand correctly, we no longer do any waiting, if that is the case, shouldn't we make sure we wait for the extension state to change?
Maybe with something similar to poll_query_until?
There was a problem hiding this comment.
Timeouts are not required here as this is a very simple function call that should return immediately. We still wait for the response from the server.
https://github.com/postgres/postgres/blob/master/src/test/perl/README
The extension tap test is very flakey and seems to fail very often with unhelpful error messages. This patch simplifies the test to make it more reliable.
Disable-check: force-changelog-file