Set NONCONTIGUOUS status flag upon OSM chunk creation #6094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In timescale#6036 we introduced a status field on the hypertable catalog table, to indicate whether an OSM chunk exists and if its range is noncontiguous. When an OSM chunk was attached to a hypertable, the noncontiguous flag was not set because the expectation was for the OSM extension to update this with an API call when data was actually moved inside OSM from timescaledb. However, this would create compatibility issues because the new version of OSM will not be rolled out at the same time as the new version of timescaledb. This commit sets the noncontiguous flag upon new OSM chunk creation to ensure backwards compatibility. However it should be reverted once the new version of OSM is deployed.
konskov
force-pushed
the
cns_dont_mark_empty
branch
from
9aa6720
to
1464505
Compare
konskov
requested review from
zilder,
svenklemm and
gayyappan
and removed request for
antekresic and
jnidzwetzki
gayyappan
approved these changes
Sep 19, 2023
zilder
approved these changes
Sep 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #6094 +/- ##
==========================================
- Coverage 74.03% 73.92% -0.12%
==========================================
Files 246 246
Lines 49811 49607 -204
Branches 12512 12452 -60
==========================================
- Hits 36878 36670 -208
- Misses 7100 7141 +41
+ Partials 5833 5796 -37
... and 35 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6036 we introduced a status field on the hypertable catalog table,
to indicate whether an OSM chunk exists and if its range is
noncontiguous.
When an OSM chunk was attached to a hypertable, the noncontiguous flag
was not set because the expectation was for the OSM extension to update
this with an API call when data was actually moved inside OSM from
timescaledb.
However, this would create compatibility issues because the new version
of OSM will not be rolled out at the same time as the new version of
timescaledb.
This commit sets the noncontiguous flag upon new OSM chunk creation to
ensure backwards compatibility. However it should be reverted once the
new version of OSM is deployed.