Make agg_partials_pushdown test more predictable #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the parallel query plans of the agg_partials_pushdown test were not deterministic since multiple workers were used and the parallel session leader also participated in query processing. This makes it impossible to predict which worker would process how many tuples. With this patch, the number of parallel workers for the agg_partials_pushdown test has been reduced to 1 and the parallel_leader_participation has been disabled to ensure deterministic query plans.
|
@nikkhils, @mahipv: please review this pull request.
|
fabriziomello
approved these changes
Oct 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #6172 +/- ##
==========================================
- Coverage 81.44% 81.41% -0.03%
==========================================
Files 246 246
Lines 56974 56928 -46
Branches 12624 12605 -19
==========================================
- Hits 46400 46348 -52
+ Misses 8196 8190 -6
- Partials 2378 2390 +12 see 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the parallel query plans of the agg_partials_pushdown test were not deterministic since multiple workers were used and the parallel session leader also participated in query processing. This makes it impossible to predict which worker would process how many tuples. With this patch, the number of parallel workers for the agg_partials_pushdown test has been reduced to 1 and the parallel_leader_participation has been disabled to ensure deterministic query plans.
--
Failed CI run: https://github.com/timescale/timescaledb/actions/runs/6448252405/job/17505323789?pr=6164
Disable-check: force-changelog-file