PG16: Fix JOIN behaviour #6226
Merged
PG16: Fix JOIN behaviour #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PG16 will remove RelOptInfo entries from root->simple_rel_array when it considers them not needed in analyzejoins.c to prevent reprocessing them. Due to this a relation may be present in root->simple_rte_array but have no corresponding entry in root->simple_rel_array. This patch adds a check for this case. postgres/postgres@e9a20e45
|
@jnidzwetzki, @nikkhils: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #6226 +/- ##
==========================================
- Coverage 65.11% 65.08% -0.04%
==========================================
Files 246 246
Lines 56957 56957
Branches 12621 12621
==========================================
- Hits 37086 37068 -18
- Misses 18026 18037 +11
- Partials 1845 1852 +7
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fabriziomello
approved these changes
Oct 24, 2023
antekresic
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG16 will remove RelOptInfo entries from root->simple_rel_array when it considers them not needed in analyzejoins.c to prevent reprocessing them. Due to this a relation may be present in root->simple_rte_array but have no corresponding entry in root->simple_rel_array. This patch adds a check for this case.
postgres/postgres@e9a20e45
Disable-check: force-changelog-file