Use "dylib" uniformly on MacOSX #6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akuzm, @jnidzwetzki: please review this pull request.
|
nikkhils
requested review from
konskov,
mkindahl and
fabriziomello
and removed request for
jnidzwetzki and
akuzm
mkindahl
approved these changes
Oct 26, 2023
konskov
approved these changes
Oct 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #6234 +/- ##
==========================================
- Coverage 65.08% 65.06% -0.03%
==========================================
Files 246 246
Lines 57035 56989 -46
Branches 12644 12625 -19
==========================================
- Hits 37123 37080 -43
- Misses 18046 18060 +14
+ Partials 1866 1849 -17 see 68 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Till PG15, shared libraries with ".so" suffix used to be loaded properly on MacOSX. That has changed with PG16. Change it so that shared libraries will uniformly use the ".dylib" suffix on MacOSX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till PG15, shared libraries with ".so" suffix used to be loaded properly on MacOSX. That has changed with PG16. Change it so that shared libraries will uniformly use the ".dylib" suffix on MacOSX
Disable-check: force-changelog-file