Remove unused segmentby_index_index from struct RowCompressor #6379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was added in fb0df1a but never actually used for anything.
|
@jnidzwetzki, @gayyappan: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6379 +/- ##
===========================================
- Coverage 86.96% 65.35% -21.61%
===========================================
Files 249 249
Lines 58009 57959 -50
Branches 12920 12900 -20
===========================================
- Hits 50447 37879 -12568
- Misses 5170 18237 +13067
+ Partials 2392 1843 -549 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
approved these changes
Dec 5, 2023
akuzm
approved these changes
Dec 5, 2023
antekresic
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was added in fb0df1a but never actually used for anything.
Disable-check: force-changelog-file