Fix coverity scan logically dead code

[fabriziomello]

https://scan4.scan.coverity.com/reports.htm#v54116/p12995/fileInstanceId=143855089&defectInstanceId=14714889&mergedDefectId=384044 https://scan4.scan.coverity.com/reports.htm#v54116/p12995/fileInstanceId=143855089&defectInstanceId=14714890&mergedDefectId=378576

Disable-check: force-changelog-file

[github-actions]

@erimatnor, @mkindahl: please review this pull request.

Powered by pull-review

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ecce0d) 87.33% compared to head (a189989) 87.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6451      +/-   ##
==========================================
- Coverage   87.33%   87.33%   -0.01%     
==========================================
  Files         187      187              
  Lines       41846    41793      -53     
  Branches     9314     9292      -22     
==========================================
- Hits        36545    36498      -47     
+ Misses       3626     3620       -6     
  Partials     1675     1675              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jnidzwetzki]

Added a comment that should be checked before merging. The rest looks good to me.

[jnidzwetzki]

I am wondering what happens in this case: Since we now remove the else statement, view_query could be uninitialized in line 149. If !agg->data.materialized_only in line 153 is also false, the variable stays uninitialized and we will access the NULL pointer in line 181.

Even if the condition is true, passing the uninitialized view_query to build_union_query looks suspicious. However, our test cases do not fail and these branches are marked as dead code. But could you double-check that this is not a problem before merging?

[fabriziomello]

It will not happen because in the current logic the only way to this happen is if the finalized=false and in that case we are exiting earlier of the function emitting a warning message.

[fabriziomello]

Anyway removed the branch because it become useless at this point.

[timescale-automation]

Automated backport to 2.13.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.13.x
You are currently cherry-picking commit 5e318c480.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tsl/src/continuous_aggs/repair.c

no changes added to commit (use "git add" and/or "git commit -a")

Job log