Disallow database connection in pg_dump #6453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6453 +/- ##
==========================================
- Coverage 87.31% 87.30% -0.02%
==========================================
Files 187 187
Lines 41846 41800 -46
Branches 9314 9294 -20
==========================================
- Hits 36537 36492 -45
+ Misses 3638 3635 -3
- Partials 1671 1673 +2 ☔ View full report in Codecov by Sentry. |
svenklemm
approved these changes
Dec 21, 2023
Another try to reduce the flakiness of this test. Previously added REVOKE CONNECT does not stop db owners or superusers connecting. Altering the database with allow_connections = off should stop everybody from connecting.
antekresic
force-pushed
the
fix-pg-dump
branch
from
5640948
to
2b7c7c1
Compare
|
@mahipv, @jnidzwetzki: please review this pull request.
|
akuzm
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try to reduce the flakiness of this test. Previously added REVOKE CONNECT does not stop db owners or superusers connecting. Altering the database with allow_connections = off should stop everybody from connecting.
Disable-check: force-changelog-file