Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable changelog check for backports #6499

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

jnidzwetzki
Copy link
Contributor

@jnidzwetzki jnidzwetzki commented Jan 5, 2024

So far, we have also checked the changelog files on our backport branch. However, the test always failed since the backported PR numbers did not match the changelog PR numbers. This PR disables the changelog check on the backport branch.


Disable-check: force-changelog-file
Link to failed CI run: https://github.com/timescale/timescaledb/actions/runs/7395253176/job/20118061456

Copy link

github-actions bot commented Jan 5, 2024

@akuzm, @gayyappan: please review this pull request.

Powered by pull-review

So far, we have also checked the changelog files on our backport branch.
However, the test always failed since the backported PR numbers did not
match the changelog PR numbers. This PR disables the changelog check on
the backport branch.
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58298e9) 87.34% compared to head (91f31b3) 87.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6499      +/-   ##
==========================================
- Coverage   87.34%   87.34%   -0.01%     
==========================================
  Files         187      187              
  Lines       41838    41792      -46     
  Branches     9319     9299      -20     
==========================================
- Hits        36545    36504      -41     
+ Misses       3623     3618       -5     
  Partials     1670     1670              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm
Copy link
Member

akuzm commented Jan 5, 2024

Maybe bug fix changelog entries should refer to fixed issues instead? I'm not sure why we require the PR numbers, it is inconvenient.

@jnidzwetzki
Copy link
Contributor Author

@akuzm I brought this topic up when we talked about the release process roughly one year ago. The result was we don't want to change it at the moment since not all bugs and features have issues.

So, merging the PR in the current state for now.

@jnidzwetzki jnidzwetzki merged commit 58859cb into timescale:main Jan 9, 2024
42 checks passed
@jnidzwetzki jnidzwetzki deleted the restrict_changelog branch January 9, 2024 12:52
@akuzm
Copy link
Member

akuzm commented Jan 9, 2024

@akuzm I brought this topic up when we talked about the release process roughly one year ago. The result was we don't want to change it at the moment since not all bugs and features have issues.

This is true, but we can make it more flexible by allowing issue numbers as well as PR numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants