-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable changelog check for backports #6499
Conversation
@akuzm, @gayyappan: please review this pull request.
|
So far, we have also checked the changelog files on our backport branch. However, the test always failed since the backported PR numbers did not match the changelog PR numbers. This PR disables the changelog check on the backport branch.
2f53c71
to
91f31b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6499 +/- ##
==========================================
- Coverage 87.34% 87.34% -0.01%
==========================================
Files 187 187
Lines 41838 41792 -46
Branches 9319 9299 -20
==========================================
- Hits 36545 36504 -41
+ Misses 3623 3618 -5
Partials 1670 1670 ☔ View full report in Codecov by Sentry. |
Maybe bug fix changelog entries should refer to fixed issues instead? I'm not sure why we require the PR numbers, it is inconvenient. |
@akuzm I brought this topic up when we talked about the release process roughly one year ago. The result was we don't want to change it at the moment since not all bugs and features have issues. So, merging the PR in the current state for now. |
This is true, but we can make it more flexible by allowing issue numbers as well as PR numbers. |
So far, we have also checked the changelog files on our backport branch. However, the test always failed since the backported PR numbers did not match the changelog PR numbers. This PR disables the changelog check on the backport branch.
Disable-check: force-changelog-file
Link to failed CI run: https://github.com/timescale/timescaledb/actions/runs/7395253176/job/20118061456