Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS X build #6503

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix OS X build #6503

merged 1 commit into from
Jan 9, 2024

Conversation

jnidzwetzki
Copy link
Contributor

@jnidzwetzki jnidzwetzki commented Jan 9, 2024

The OS X build currently fails with a brew link error for Python. This PR fixes the problem by allowing the overwriting of existing files in the Python install step.


Disable-check: force-changelog-file
Failed CI run: https://github.com/timescale/timescaledb/actions/runs/7458415023/job/20292684115?pr=6497
Fixed CI run: https://github.com/timescale/timescaledb/actions/runs/7458792901/job/20293479793?pr=6503

The OS X build currently fails with a brew link error for Python. This
PR fixes the problem by allowing the overwriting of existing files in
the Python install step.
@jnidzwetzki jnidzwetzki marked this pull request as ready for review January 9, 2024 09:05
Copy link

github-actions bot commented Jan 9, 2024

@gayyappan, @akuzm: please review this pull request.

Powered by pull-review

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58298e9) 87.35% compared to head (204bcda) 87.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6503      +/-   ##
==========================================
- Coverage   87.35%   87.31%   -0.05%     
==========================================
  Files         187      187              
  Lines       41838    41792      -46     
  Branches     9319     9299      -20     
==========================================
- Hits        36548    36490      -58     
- Misses       3623     3629       +6     
- Partials     1667     1673       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnidzwetzki jnidzwetzki enabled auto-merge (rebase) January 9, 2024 09:14
@jnidzwetzki jnidzwetzki merged commit 3fef7a9 into timescale:main Jan 9, 2024
53 of 54 checks passed
@jnidzwetzki jnidzwetzki deleted the fix_homebrew branch January 9, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants