Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the spelling in our code #6511

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Check the spelling in our code #6511

merged 1 commit into from
Jan 11, 2024

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jan 10, 2024

Use codespell. It works well enough for everything except Python where it tries to edit GraphQL API calls and regular expressions, so I don't run it for Python scripts.

Disable-check: force-changelog-file

Copy link

@antekresic, @mahipv: please review this pull request.

Powered by pull-review

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (662fcc1) 87.34% compared to head (0ac41af) 87.33%.

❗ Current head 0ac41af differs from pull request most recent head 9792f9d. Consider uploading reports for the commit 9792f9d to get more accurate results

Files Patch % Lines
tsl/src/compression/api.c 0.00% 1 Missing ⚠️
tsl/src/compression/compression_test.c 0.00% 1 Missing ⚠️
tsl/src/compression/simple8b_rle.h 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6511      +/-   ##
==========================================
- Coverage   87.34%   87.33%   -0.02%     
==========================================
  Files         187      187              
  Lines       41906    41858      -48     
  Branches     9335     9313      -22     
==========================================
- Hits        36602    36555      -47     
+ Misses       3635     3624      -11     
- Partials     1669     1679      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@antekresic antekresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@akuzm akuzm enabled auto-merge (rebase) January 11, 2024 10:38
@akuzm akuzm merged commit f08dd10 into timescale:main Jan 11, 2024
45 of 46 checks passed
@akuzm akuzm deleted the codespell branch January 11, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants