Verify compression configuration on compression rollup #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkindahl, @jnidzwetzki: please review this pull request.
|
mkindahl
approved these changes
Jan 25, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6564 +/- ##
=======================================
Coverage 79.72% 79.72%
=======================================
Files 188 188
Lines 36718 36690 -28
Branches 9280 9270 -10
=======================================
- Hits 29274 29252 -22
- Misses 3113 3117 +4
+ Partials 4331 4321 -10 ☔ View full report in Codecov by Sentry. |
|
Will add tests once #6545 is merged. |
antekresic
approved these changes
Jan 25, 2024
svenklemm
force-pushed
the
compress_rollup_checks
branch
from
11576a5
to
3328520
Compare
Add a check to verify compression settings for chunks to be rolled up are identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to verify compression settings for chunks to be rolled up are identical.