Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust .gitignore for transparent_decompression test files #6568

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

svenklemm
Copy link
Member

No description provided.

Copy link

@fabriziomello, @nikkhils: please review this pull request.

Powered by pull-review

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83ff966) 79.73% compared to head (73891f8) 79.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6568      +/-   ##
==========================================
+ Coverage   79.73%   79.75%   +0.01%     
==========================================
  Files         188      188              
  Lines       36736    36690      -46     
  Branches     9287     9270      -17     
==========================================
- Hits        29292    29262      -30     
+ Misses       3111     3108       -3     
+ Partials     4333     4320      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jnidzwetzki jnidzwetzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. However, check_missing_gitignore_for_template_tests.sh complains and might also need some adjustments.

Missing entry in tsl/test/sql/.gitignore for template file tsl/test/sql/transparent_decompression.sql.in
Missing entry in tsl/test/sql/.gitignore for template file tsl/test/sql/transparent_decompression_ordered_index.sql.in

Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of generated files in the source tree. These would be better placed in the build tree and then we would not have to update .gitignore all the time. However, that is work for a rainy day.

@svenklemm svenklemm merged commit 50c757c into timescale:main Jan 29, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants