Remove double initialization of time_bucket origin #6588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnidzwetzki
commented
Feb 1, 2024
| @@ -272,11 +272,6 @@ ts_timestamptz_bucket(PG_FUNCTION_ARGS) | |||
| if (TIMESTAMP_NOT_FINITE(timestamp)) | |||
| PG_RETURN_TIMESTAMPTZ(timestamp); | |||
|
|
|||
| if (PG_NARGS() > 2) | |||
There was a problem hiding this comment.
Already initialized in line 269
The variable origin in ts_timestamptz_bucket was initialized two times. This commit removes one of the initializations.
jnidzwetzki
force-pushed
the
timebucket_remove_double_origin
branch
from
9d7ff11
to
05aebb0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6588 +/- ##
==========================================
+ Coverage 79.80% 79.83% +0.02%
==========================================
Files 190 190
Lines 37264 37216 -48
Branches 9444 9426 -18
==========================================
- Hits 29740 29710 -30
+ Misses 3128 3122 -6
+ Partials 4396 4384 -12 ☔ View full report in Codecov by Sentry. |
|
@erimatnor, @mkindahl: please review this pull request.
|
mkindahl
approved these changes
Feb 1, 2024
antekresic
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable origin in ts_timestamptz_bucket was initialized two times. This commit removes one of the initializations.
Disable-check: force-changelog-file