Add extension namespace macro #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't replace all namespace-qualified strings using the macro, but happy to do that if you think that this is a useful change. |
mkindahl
force-pushed
the
use-extension-namespace-macro
branch
from
d632837
to
c8cb4d0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6676 +/- ##
==========================================
+ Coverage 80.06% 81.50% +1.43%
==========================================
Files 190 191 +1
Lines 37181 36417 -764
Branches 9450 9464 +14
==========================================
- Hits 29770 29682 -88
+ Misses 2997 2971 -26
+ Partials 4414 3764 -650 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
reviewed
Feb 20, 2024
fabriziomello
approved these changes
Feb 20, 2024
mkindahl
force-pushed
the
use-extension-namespace-macro
branch
from
c8cb4d0
to
51e7bb7
Compare
Replaced remaining cases (I think I got all of them). |
mkindahl
force-pushed
the
use-extension-namespace-macro
branch
2 times, most recently
from
c5cb295
to
58cc048
Compare
There is a mix of macros for extension namespace and hard-coded extension name in the code. This commit adds an `EXTENSION_NAMESPACE` macro to `extension_constants.h` and uses that instead of locally defined macros and hard-coded strings. It also adds a macro `EXTENSION_OPTION` which can be used to create a full name for an extension option using the namespace macro.
mkindahl
force-pushed
the
use-extension-namespace-macro
branch
from
58cc048
to
de84a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mix of macros for extension namespace and hard-coded extension name in the code. This commit adds an
EXTENSION_NAMESPACEmacro toextension_constants.hand uses that instead of locally defined macros and hard-coded strings. It also adds a macroEXTENSION_OPTIONwhich can be used to create a full name for an extension option using the namespace macro.Disable-check: force-changelog-file, loader-change