Simplification and cleanup of decompression planning #6731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ANALYZE after compression of `metrics_compressed` in shared test setup.
We don't account for them at all currently, which leads to weird planning behavior, like the filters not influencing the position of relations in join.
…ially_compressed-*
…ially_compressed-*
…ially_compressed-*
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6731 +/- ##
==========================================
+ Coverage 80.06% 80.99% +0.92%
==========================================
Files 190 191 +1
Lines 37181 36337 -844
Branches 9450 9432 -18
==========================================
- Hits 29770 29430 -340
- Misses 2997 3159 +162
+ Partials 4414 3748 -666 ☔ View full report in Codecov by Sentry. |
antekresic
approved these changes
Mar 5, 2024
jnidzwetzki
approved these changes
Mar 5, 2024
2 tasks
akuzm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames some things in preparation to cost changes from #6550
Also simplifies path creation for partial chunks, improving some plans (now index scans are used instead of sort).
Disable-check: force-changelog-file