Refactor parameter of invalidation_state_init #6776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the invalidation_state_init function used a loop to find the proper CAgg bucket function. This PR refactors the parameter of the function and passes the needed information directly.
jnidzwetzki
added
continuous_aggregate
refactor
tech-debt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6776 +/- ##
==========================================
+ Coverage 80.06% 80.90% +0.84%
==========================================
Files 190 191 +1
Lines 37181 36179 -1002
Branches 9450 9403 -47
==========================================
- Hits 29770 29272 -498
- Misses 2997 3164 +167
+ Partials 4414 3743 -671 ☔ View full report in Codecov by Sentry. |
fabriziomello
approved these changes
Mar 18, 2024
mkindahl
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the invalidation_state_init function used a loop to find the proper CAgg bucket function. This PR refactors the parameter of the function and passes the needed information directly.
Disable-check: force-changelog-file