Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat segmentby columns same as compressed columns with default value #6817

Merged
merged 5 commits into from Apr 12, 2024

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Apr 10, 2024

This is a minor refactoring that will later allow to simplify the vectorized aggregation code. No functional or performance changes are expected.

No changes in tsbench: https://grafana.ops.savannah-dev.timescale.com/d/fasYic_4z/compare-akuzm?orgId=1&var-branch=All&var-run1=3407&var-run2=3421&var-threshold=0&var-use_historical_thresholds=true&var-threshold_expression=2.5%20%2A%20percentile_cont%280.90%29&var-exact_suite_version=false&from=now%2Fy&to=now%2Fy

Disable-check: force-changelog-file

This is a minor refactoring that will later allow to simplify the
vectorized aggregation code. No functional or performance changes are
expected.
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 75.40984% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 80.88%. Comparing base (59f50f2) to head (5f88a23).
Report is 107 commits behind head on main.

❗ Current head 5f88a23 differs from pull request most recent head f97f2b0. Consider uploading reports for the commit f97f2b0 to get more accurate results

Files Patch % Lines
tsl/src/nodes/decompress_chunk/compressed_batch.c 76.31% 2 Missing and 7 partials ⚠️
tsl/src/nodes/decompress_chunk/exec.c 73.91% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6817      +/-   ##
==========================================
+ Coverage   80.06%   80.88%   +0.82%     
==========================================
  Files         190      194       +4     
  Lines       37181    36933     -248     
  Branches     9450     9666     +216     
==========================================
+ Hits        29770    29875     +105     
- Misses       2997     3197     +200     
+ Partials     4414     3861     -553     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm akuzm marked this pull request as ready for review April 10, 2024 14:21
Copy link
Contributor

@antekresic antekresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleaner 👍

@akuzm akuzm enabled auto-merge (squash) April 12, 2024 09:09
@akuzm akuzm merged commit 4420561 into timescale:main Apr 12, 2024
39 of 42 checks passed
@akuzm akuzm deleted the scalar branch April 12, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants