-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experiments with vectorized aggregation #6793
Draft
akuzm
wants to merge
108
commits into
timescale:main
Choose a base branch
from
akuzm:agg-experiments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a little confusing because they only live during the creation of decompression plan. Put them into a separate struct instead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6793 +/- ##
==========================================
+ Coverage 80.06% 80.68% +0.61%
==========================================
Files 190 200 +10
Lines 37181 37064 -117
Branches 9450 9670 +220
==========================================
+ Hits 29770 29906 +136
- Misses 2997 3236 +239
+ Partials 4414 3922 -492 ☔ View full report in Codecov by Sentry. |
also unroll the loop
This reverts commit 7852d55f3061b82a3ce1cf8d7575f64c2d14aa0b.
This is a minor refactoring that will later allow to simplify the vectorized aggregation code. No functional or performance changes are expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts: