Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust ordered append plan cost #1097

Merged
merged 1 commit into from Mar 8, 2019

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Mar 7, 2019

Ordered append used to only consider startup cost of the first child.
This patch changes the cost for ordered append to use the normal postgresql append cost calculation

Fixes #1090

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@300b05d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1097   +/-   ##
=========================================
  Coverage          ?   91.65%           
=========================================
  Files             ?       93           
  Lines             ?    11035           
  Branches          ?        0           
=========================================
  Hits              ?    10114           
  Misses            ?      921           
  Partials          ?        0
Impacted Files Coverage Δ
src/plan_ordered_append.c 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300b05d...9e1c755. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #1097 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
- Coverage   91.65%   91.65%   -0.01%     
==========================================
  Files          93       93              
  Lines       11037    11035       -2     
==========================================
- Hits        10116    10114       -2     
  Misses        921      921
Impacted Files Coverage Δ
src/plan_ordered_append.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300b05d...ce219fd. Read the comment docs.

@mfreed
Copy link
Member

mfreed commented Mar 8, 2019

Do you have sense how this effects planning times if there are many children?

Ordered append used to only consider startup cost of the first child.
This patch changes the cost for ordered append to also include the total
cost of the first child
@svenklemm svenklemm merged commit ed11a16 into timescale:master Mar 8, 2019
@svenklemm svenklemm added this to the 1.2.2 milestone Mar 11, 2019
@svenklemm svenklemm deleted the ordered_append_plan_cost branch October 10, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants