Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass int64 using Int64GetDatum when a Datum is required #1228

Merged
merged 1 commit into from May 23, 2019

Conversation

gayyappan
Copy link
Contributor

int64 should be passed to functions that take a Datum parameter using Int64GetDatum.
Depending on the platform, postgres either passes int64 by value or allocs a pointer
to hold this value.
Without this change, we get SEGV on raspberry pi.

@gayyappan gayyappan changed the title Pass int64 using Int64GetDatum when a Datum is required [WIP] Pass int64 using Int64GetDatum when a Datum is required May 17, 2019
@gayyappan gayyappan marked this pull request as ready for review May 17, 2019 21:41
@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #1228 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
+ Coverage   92.56%   92.56%   +<.01%     
==========================================
  Files         107      107              
  Lines       13709    13710       +1     
==========================================
+ Hits        12690    12691       +1     
  Misses       1019     1019
Impacted Files Coverage Δ
tsl/src/continuous_aggs/materialize.c 94.14% <ø> (ø) ⬆️
tsl/src/continuous_aggs/create.c 97.36% <100%> (ø) ⬆️
src/utils.c 85.42% <100%> (ø) ⬆️
tsl/test/src/test_continuous_aggs.c 95.83% <100%> (ø) ⬆️
src/loader/bgw_message_queue.c 91.6% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4a389...6341dc3. Read the comment docs.

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7d30599). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1228   +/-   ##
=========================================
  Coverage          ?   92.73%           
=========================================
  Files             ?      106           
  Lines             ?    13552           
  Branches          ?        0           
=========================================
  Hits              ?    12567           
  Misses            ?      985           
  Partials          ?        0
Impacted Files Coverage Δ
tsl/src/continuous_aggs/materialize.c 94.14% <ø> (ø)
tsl/src/continuous_aggs/create.c 97.36% <100%> (ø)
tsl/test/src/test_continuous_aggs.c 95.83% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d30599...923fac7. Read the comment docs.

@gayyappan gayyappan changed the title [WIP] Pass int64 using Int64GetDatum when a Datum is required Pass int64 using Int64GetDatum when a Datum is required May 23, 2019
@cevian cevian added the bug label May 23, 2019
int64 should be passed to functions that take a Datum parameter using Int64GetDatum.
Depending on the platform, postgres either passes int64 by value or allocs a pointer
to hold this value.
Without this change, we get SEGV on raspberry pi.
@gayyappan gayyappan merged commit 5b7eea4 into timescale:master May 23, 2019
@cevian cevian added this to the 1.3.1 milestone May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants