Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraint aware tests for compression #1507

Merged
merged 1 commit into from Nov 7, 2019

Conversation

gayyappan
Copy link
Contributor

@gayyappan gayyappan commented Oct 30, 2019

  1. This commit introduces changes to expected plan output due
    to the addition of new chunks to metrics_ordered_idx.
  2. Add tests for constraint aware appends on compressed
    tables.

@gayyappan gayyappan changed the title Add constraint aware tests for compression [WIP] Add constraint aware tests for compression Oct 30, 2019
@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #1507 into master will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
+ Coverage   91.44%   91.81%   +0.37%     
==========================================
  Files         144      142       -2     
  Lines       21443    20512     -931     
==========================================
- Hits        19608    18833     -775     
+ Misses       1835     1679     -156
Flag Coverage Δ
#cron ?
#pr 91.81% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
src/plan_add_hashagg.c 43.33% <0%> (-45.01%) ⬇️
src/telemetry/uuid.c 84.61% <0%> (-15.39%) ⬇️
src/planner_import.c 58.65% <0%> (-10.95%) ⬇️
src/cache_invalidate.c 78.12% <0%> (-2.44%) ⬇️
src/bgw_policy/chunk_stats.c 83.92% <0%> (-1.56%) ⬇️
src/loader/loader.c 91.57% <0%> (-1.25%) ⬇️
src/histogram.c 89.02% <0%> (-1.22%) ⬇️
src/estimate.c 86.17% <0%> (-0.83%) ⬇️
src/telemetry/telemetry.c 79.55% <0%> (-0.71%) ⬇️
src/cache.c 84.82% <0%> (-0.65%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f8621...dcb480e. Read the comment docs.

@gayyappan gayyappan marked this pull request as ready for review October 31, 2019 15:09
@gayyappan gayyappan changed the title [WIP] Add constraint aware tests for compression Add constraint aware tests for compression Nov 5, 2019
@gayyappan gayyappan force-pushed the compress_fix branch 2 times, most recently from b670938 to c198bde Compare November 5, 2019 18:49
@gayyappan gayyappan requested a review from cevian November 5, 2019 20:29
1. This commit introduces changes to existing plans due
to the addition of new chunks to metrics_ordered_idx.
2. Add tests for constraint aware appends on compressed
tables.
@gayyappan gayyappan merged commit 3e5e0de into timescale:master Nov 7, 2019
@cevian cevian added this to the 1.6.0 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants